[Intel-gfx] [PATCH] drm/i915/userptr: Convert to drm_i915_private

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Mon May 23 10:17:38 UTC 2016


On to, 2016-05-19 at 16:17 +0100, Chris Wilson wrote:
> -int
> -i915_gem_init_userptr(struct drm_device *dev)
> +void i915_gem_init_userptr(struct drm_i915_private *dev_priv)
>  {
> -	struct drm_i915_private *dev_priv = to_i915(dev);
>  	mutex_init(&dev_priv->mm_lock);
>  	hash_init(dev_priv->mm_structs);
>  	return 0;

You should remove the "return 0;" if you make the function void, and
maybe also make a not int he commit message.

With that,

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas

-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list