[Intel-gfx] [PATCH 10/12] drm/i915: Merge legacy+execlists context structs

[Chris Wilson]

On Mon, May 23, 2016 at 11:26:13AM +0100, Tvrtko Ursulin wrote:
> >@@ -400,7 +412,7 @@ int i915_gem_context_init(struct drm_device *dev)
> >  		return PTR_ERR(ctx);
> >  	}
> >
> >-	if (ctx->legacy_hw_ctx.rcs_state) {
> >+	if (ctx->engine[RCS].state) {
> 
> Maybe now put a comment saying this is for legacy now, to make the
> asymmetry in ctx pinning paths between the two stick out more.

Good point. This needs the i915.enable_execlists markup. Ultimately, I
think we should move the pin/unpin into the legacy engine setup for
symmetry with execlists (and killing off one more pair of
i915.enable_execlists).
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre