[Intel-gfx] [PATCH] drm/i915/guc: Disable automatic GuC firmware loading

[Chris Wilson]

On Mon, May 23, 2016 at 04:34:35PM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> New GuC code is logging errors at runtime suspend and resume which
> causes CI testing to log "orange" status. Default to not trying to
> load the firmware until this is resolved.
> 
> Example of the log:
> 
>  [drm] RC6 on
>  [drm:intel_runtime_suspend] Suspending device
>  [drm:host2guc_action [i915]] *ERROR* GUC: host2guc action 0x501 failed. ret=-110 status=0x00000501 response=0x40000000
>  ...
>  [drm:intel_runtime_resume] Resuming device
>  [drm:host2guc_action [i915]] *ERROR* GUC: host2guc action 0x502 failed. ret=-110 status=0x00000502 response=0x40000000
>  [drm:intel_runtime_resume] Device resumed
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Cc: Dave Gordon <david.s.gordon at intel.com>
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Cc: Chris Harris <chris.harris at intel.com>
> ---
>  drivers/gpu/drm/i915/i915_params.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index 21a323c01cdb..9a5d58b251f5 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -53,7 +53,7 @@ struct i915_params i915 __read_mostly = {
>  	.verbose_state_checks = 1,
>  	.nuclear_pageflip = 0,
>  	.edp_vswing = 0,
> -	.enable_guc_loading = -1,
> +	.enable_guc_loading = 0,
>  	.enable_guc_submission = 0,
>  	.guc_log_level = -1,
>  	.enable_dp_mst = true,
> @@ -197,7 +197,7 @@ MODULE_PARM_DESC(edp_vswing,
>  module_param_named_unsafe(enable_guc_loading, i915.enable_guc_loading, int, 0400);
>  MODULE_PARM_DESC(enable_guc_loading,
>  		"Enable GuC firmware loading "
> -		"(-1=auto [default], 0=never, 1=if available, 2=required)");
> +		"(-1=auto, 0=never [default], 1=if available, 2=required)");
>  
>  module_param_named_unsafe(enable_guc_submission, i915.enable_guc_submission, int, 0400);
>  MODULE_PARM_DESC(enable_guc_submission,

Patch does what it says on the tin,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Not thrilled by the [soft] ABI of i915.enable_guc_loading though.
That looks like an internal dependency of various GuC enabled features
and not a standalone feature that the user should be controlling.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre