[Intel-gfx] [PATCH] drm/i915: Skip idling an idle engine

Chris Wilson chris at chris-wilson.co.uk
Wed May 25 09:00:12 UTC 2016


On Wed, May 25, 2016 at 11:50:22AM +0300, Joonas Lahtinen wrote:
> On ti, 2016-05-24 at 11:56 +0100, Chris Wilson wrote:
> > During suspend (or module unload), if we have never accessed the engine
> > (i.e. userspace never submitted a batch to it), the engine is idle. Then
> > we attempt to idle the engine by forcing it to the default context,
> > which actually means we submit a render batch to setup the golden
> > context state and then wait for it to complete. We can skip this
> > entirely as we know the engine is idle.
> > 
> 
> Seems reasonable.
> 
> By quick look we do not have an inactive engine list, though? So the
> comment above could be nuked.

It dates from when i915_gpu_idle() also did retire-requests as well, and
the inactive list on the engine rather than the vm.

I've a few more in this re bug 95634, just need to finish rebasing.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list