[Intel-gfx] [PATCH 01/11] drm: Export drm_dev_init() for subclassing

[Emil Velikov]

On 27 May 2016 at 16:36, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> On Fri, May 27, 2016 at 05:29:43PM +0200, Nils Wallménius wrote:
>>    Hi, Chris
>>
>>    See comment below
>>
>>    >  err_setunique:
>>    >         if (drm_core_check_feature(dev, DRIVER_GEM))
>>    > @@ -653,8 +650,46 @@ err_minors:
>>    >         drm_fs_inode_free(dev->anon_inode);
>>    >  err_free:
>>    >         mutex_destroy(&dev->master_mutex);
>>    > -       kfree(dev);
>>    > -       return NULL;
>>    > +       return 0;
>>
>>    Shouldn't this return != 0?
>
> You saw nothing, it always said return ret!
Chris can you please elaborate ? I believe Nils has a point here.

Afact the error path of _init should return != 0, plus you already
handle that case in _alloc, yet the function always returns 0.

Regards,
Emil