[Intel-gfx] [RFC 09/12] drm/i915: Add a char device file interface to capture GuC ukernel logs

[Goel, Akash]

On 5/28/2016 1:18 AM, Chris Wilson wrote:
> On Sat, May 28, 2016 at 01:13:00AM +0530, akash.goel at intel.com wrote:
>> From: Akash Goel <akash.goel at intel.com>
>>
>> This patch provides a new character device file interface '/dev/dri/guc_log'
>> for the User to capture the GuC ukernel logs.
>
> Do not make the device conditional on !CONFIG_DEBUGFS.
> With a stable interface like the device, you do not need a debugfs
> entry.

Sorry, actually I was unsure, don't know which interface would be most 
appropriate here.
Thought if CONFIG_DEBUG_FS is defined, then relay backed debugfs file 
might be the most preferred interface, in which case device file 
interface may not be required.

If device file interface is most suitable, then may not have a relay 
backed debugfs interface.

Please suggest.

Best regards
Akash
> -Chris
>