[Intel-gfx] [PATCH] drm/i915: Remove drm_i915_private->dev backpointer

Chris Wilson chris at chris-wilson.co.uk
Mon May 30 08:21:47 UTC 2016


On Mon, May 30, 2016 at 09:58:15AM +0300, Joonas Lahtinen wrote:
> On pe, 2016-05-27 at 15:46 +0100, Chris Wilson wrote:
> > Now that drm_i915_private contains drm_device, we can directly go to the
> > drm_device as required:
> > 
> >    text	   data	    bss	    dec	    hex	filename
> > 1105153	  23207	    416	1128776	 113948	i915.ko (before)
> > 1102849	  23207	    416	1126472	 113048	i915.ko (after)
> > 
> > s/dev_priv->dev->/dev_priv->drm./
> > s/dev_priv->dev/\&dev_priv->drm./
> 
> Lose the dot from last replaement pattern, and I'm also pretty sure \
> is not needed in front of &

It's a vim sed line, since I was working inside vim checking the
results. (Hand copied, hence the extra .)

A bigger change that I think Dave Gordon has the coccinelle scripts for
is s/dev->dev_private/to_i915(dev)/ . We still have something like 600
sites that we can fix up.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list