[Intel-gfx] [PATCH 1/1] drm/i915: Update GEN6_PMINTRMSK setup with GuC submission

Chris Wilson chris at chris-wilson.co.uk
Mon May 30 10:08:15 UTC 2016


On Mon, May 30, 2016 at 03:22:31PM +0530, Sagar Arun Kamble wrote:
> On Loading, GuC sets PM interrupts routing (bit 31) and unmasks ARAT
> expired interrupt (bit 9). Host turbo also updates this register
> in RPS flows. This patch ensures bit 31 and bit 9 setup by GuC persists.
> ARAT timer interrupt is needed in GuC for various features. It also
> facilitates halting GuC and hence achieving RC6. PM interrupt routing
> will not impact RPS interrupt reception by host as GuC will redirect
> them.
> This patch fixes igt test pm_rc6_residency. Tested with SKL GuC v6.1
> and BXT GuC v5.1 and v8.7.

i915_irq/intel_pm do not want to be mucking around inside intel_guc.

Move the mask to dev_priv->rps, have it initialised during early irq
setup and modify the mask when guc loads (presumably also triggering a
resanitize just in case).
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list