[Intel-gfx] [PATCH 00/26] drm/i915: A game of OCD dominoes

[Ville Syrjälä]

On Mon, Oct 31, 2016 at 08:56:34PM +0000, Chris Wilson wrote:
> On Mon, Oct 31, 2016 at 10:36:59PM +0200, ville.syrjala at linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > I pretty much just wanted to store struct intel_crtc * instead
> > of struct drm_crtc * in pipe_to_crtc_mapping[] & co. but to
> > achieve it cleanly I ended up chasing quite few different things
> > that were accepting the wrong kind of type. And once I had
> > sorted out those mappign arrays, I had ended up in the old
> > watermark code which kept me busy for another good while.
> > Eventually I was able to claw my way back to sanity and I
> > decided to stop.
> > 
> > I'm going to blame Daniel for getting me on this track by
> > suggesting that I should pass dev_priv to the plane
> > constructos. That was enough of a trigger to get me started.
> > 
> > Entire series available here:
> > git://github.com/vsyrjala/linux.git dev_priv_intel_crtc_cleanup
> > 
> > Ville Syrjälä (26):
> >   drm/i915: Pass dev_priv to plane constructors
> >   drm/i915: Pass dev_priv to skl_init_scalers()
> >   drm/i915: Pass intel_crtc to intel_crtc_active()
> >   drm/i915: Pass intel_crtc to update_wm functions
> >   drm/i915: Use struct intel_crtc in legacy platform wm code
> >   drm/i915: Store struct intel_crtc * in {pipe,plane}_to_crtc_mapping[]
> >   drm/i915: Pass dev_priv to intel_wait_for_vblank()
> >   drm/i915: Pass dev_priv to vlv force pll functions
> >   drm/i915: Pass dev_priv to g4x wm functions
> >   drm/i915: Pass dev_priv to intel_get_crtc_for_pipe()
> >   drm/i915: Always use intel_get_crtc_for_pipe()
> >   drm/i915: Pass dev_priv to intel_crtc_init()
> >   drm/i915: Pass dev_priv to cdclk update funcs
> >   drm/i915: Pass dev_priv to .get_display_clock_speed()
> >   drm/i915: Pass dev_priv to IS_MOBILE()
> >   drm/i915: Pass dev_priv to IS_PINEVIEW()
> >   drm/i915: Pass dev_priv to i915_pineview_get_mem_freq() and
> >     i915_ironlake_get_mem_freq()
> >   drm/i915: Pass dev_priv to .get_fifo_size()
> >   drm/i915: Pass dev_priv to HAS_FW_BLC
> >   drm/i915: Pass dev_priv to IS_BROADWATER/IS_CRESTLINE
> >   drm/i915: Pass dev_priv to rest of IS_FOO() macros for the old
> >     platforms
> >   drm/i915: Pass dev_priv to single_enabled_crtc()
> >   drm/i915: Pass dev_priv to init_clock_gating
> >   drm/i915: Pass dev_priv to intel_suspend_hw()
> >   drm/i915: Pass dev_priv to ilk_setup_wm_latency() & co.
> >   drm/i915: Pass dev_priv to intel_init_pm()
> 
> All looked reasonable and beguiling in their simplicty. Nice trimming.
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> Are we still trimming the odd byte from object size?

-.text                        850282      0
+.text                        850218      0

:)

-- 
Ville Syrjälä
Intel OTC