[Intel-gfx] [PATCH 1/2] drm/i915: Move hangcheck code out from i915_irq.c

Mika Kuoppala mika.kuoppala at linux.intel.com
Tue Nov 1 16:39:54 UTC 2016


Chris Wilson <chris at chris-wilson.co.uk> writes:

> On Tue, Nov 01, 2016 at 06:03:21PM +0200, Mika Kuoppala wrote:
>> Create new file for hangcheck specific code, intel_engine_hangcheck.c,
>> and move all the related code in it.
>> 
>> No functional changes.
>> 
>> Cc: Chris Wilson <chris at chris-wilson.co.uk>
>> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>> Signed-off-by: Mika Kuoppala <mika.kuoppala at intel.com>
>> ---
>>  drivers/gpu/drm/i915/Makefile                 |   1 +
>>  drivers/gpu/drm/i915/i915_drv.c               |   1 +
>>  drivers/gpu/drm/i915/i915_drv.h               |   1 +
>>  drivers/gpu/drm/i915/i915_irq.c               | 417 ------------------------
>>  drivers/gpu/drm/i915/intel_engine_cs.c        |   5 -
>>  drivers/gpu/drm/i915/intel_engine_hangcheck.c | 450 ++++++++++++++++++++++++++
>>  6 files changed, 453 insertions(+), 422 deletions(-)
>>  create mode 100644 drivers/gpu/drm/i915/intel_engine_hangcheck.c
>> 
>> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
>> index 240ce9a..e772664 100644
>> --- a/drivers/gpu/drm/i915/Makefile
>> +++ b/drivers/gpu/drm/i915/Makefile
>> @@ -47,6 +47,7 @@ i915-y += i915_cmd_parser.o \
>>  	  i915_trace_points.o \
>>  	  intel_breadcrumbs.o \
>>  	  intel_engine_cs.o \
>> +	  intel_engine_hangcheck.o \
>
> Hmm. intel_engine_hangcheck. Please do include a signpost as to why this
> makes more sense than intel_hangcheck.c

intel_hangcheck.c makes more sense. New version soon.
-Mika

> -Chris
>
> -- 
> Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list