[Intel-gfx] [PATCH] drm: move allocation out of drm_get_format_name()

Christian König christian.koenig at amd.com
Sat Nov 5 12:11:36 UTC 2016


Am 05.11.2016 um 02:33 schrieb Eric Engestrom:
> +typedef char drm_format_name_buf[32];

Please don't use a typedef for this, just define the maximum size of 
characters the function might write somewhere.

See the kernel coding style as well:
> In general, a pointer, or a struct that has elements that can reasonably
> be directly accessed should **never** be a typedef.

Regards,
Christian.


More information about the Intel-gfx mailing list