[Intel-gfx] [PATCH 05/12] drm/i915/scheduler: Record all dependencies upon request construction

[Tvrtko Ursulin]

On 04/11/2016 15:11, Chris Wilson wrote:
> On Fri, Nov 04, 2016 at 02:44:44PM +0000, Tvrtko Ursulin wrote:
>>
>> On 03/11/2016 11:55, Chris Wilson wrote:
>>> On Thu, Nov 03, 2016 at 11:03:47AM +0000, Tvrtko Ursulin wrote:
>>>>
>>>> On 02/11/2016 17:50, Chris Wilson wrote:
>>>>> +struct i915_dependency {
>>>>> +	struct i915_priotree *signal;
>>>>> +	struct list_head pre_link, post_link;
>>>>> +	unsigned long flags;
>>>>> +#define I915_DEPENDENCY_ALLOC BIT(0)
>>>>> +};
>>>>> +
>>>>> +struct i915_priotree {
>>>>> +	struct list_head pre_list; /* who is before us, we depend upon */
>>>>> +	struct list_head post_list; /* who is after us, they depend upon us */
>>>>> +};
>>>>
>>>> I need a picture to imagine this data structure. :(
>>>
>>> The names suck.
>>
>> When you wrote this I assumed you would respin shortly with some
>> better names?
>
> Not yet. I kind of like
>
> struct i915_dependency {
> 	struct i915_priotree *signaler;
> 	struct list_head signaler_link;
> 	struct list_head listener_link;
> };
>
> struct i915_priotree {
> 	struct list_head signalers_list; /* before us, we depend on them */
> 	struct list_head listeners_list; /* those after, who depend on us */
> };
>

What is the signaler in i915_dependency?

Regards,

Tvrtko