[Intel-gfx] [bug report] drm/i915/gvt: vGPU display virtualization

Dan Carpenter dan.carpenter at oracle.com
Thu Nov 10 12:54:51 UTC 2016


Hello Zhi Wang,

The patch 04d348ae3f0a: "drm/i915/gvt: vGPU display virtualization"
from Apr 25, 2016, leads to the following static checker warning:

	drivers/gpu/drm/i915/gvt/edid.c:506 intel_gvt_i2c_handle_aux_ch_write()
	warn: odd binop '0x0 & 0xff'

drivers/gpu/drm/i915/gvt/edid.c
   501          /* write the return value in AUX_CH_DATA reg which includes:
   502           * ACK of I2C_WRITE
   503           * returned byte if it is READ
   504           */
   505  
   506          aux_data_for_write |= (GVT_AUX_I2C_REPLY_ACK & 0xff) << 24;

GVT_AUX_I2C_REPLY_ACK is 0 << 6.  Which is weird.  The whole line is a
no-op.

   507          vgpu_vreg(vgpu, offset + 4) = aux_data_for_write;
   508  }

regards,
dan carpenter


More information about the Intel-gfx mailing list