[Intel-gfx] [PATCH v2 06/11] drm/i915/scheduler: Record all dependencies upon request construction

Chris Wilson chris at chris-wilson.co.uk
Thu Nov 10 15:55:05 UTC 2016


On Thu, Nov 10, 2016 at 03:36:17PM +0000, Tvrtko Ursulin wrote:
> 
> On 10/11/2016 15:01, Chris Wilson wrote:
> >On Thu, Nov 10, 2016 at 02:45:39PM +0000, Tvrtko Ursulin wrote:
> >>
> >>On 07/11/2016 13:59, Chris Wilson wrote:
> >>>+	/* Recursively bump all dependent priorities to match the new request */
> >>>+	list_for_each_entry_safe(dep, p, &dfs, dfs_link) {
> >>>+		struct i915_priotree *pt = dep->signaler;
> >>>+
> >>>+		list_for_each_entry(p, &pt->signalers_list, signal_link)
> >>>+			if (prio > READ_ONCE(p->signaler->priority))
> >>>+				list_move_tail(&p->dfs_link, &dfs);
> >>>+
> >>>+		p = list_first_entry(&dep->dfs_link, typeof(*p), dfs_link);
> >>
> >>This was fun. :)
> 
> Maybe clearer as:
> 
> p = list_next_entry(dep, typeof(*p), dfs_link) ?

Fancy.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list