[Intel-gfx] [PATCH i-g-t] lib: Pass I915_TILING_Y to the kernel if Yf or Ys

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Thu Nov 10 16:18:23 UTC 2016


On 10/11/2016 10:15, Tomeu Vizoso wrote:
> GEM_SET_TILING doesn't care about Yf or Ys, so just pass Y.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>
> ---
>  lib/ioctl_wrappers.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
> index 95bc5e268bcd..eabf3ee3abe6 100644
> --- a/lib/ioctl_wrappers.c
> +++ b/lib/ioctl_wrappers.c
> @@ -158,6 +158,9 @@ int __gem_set_tiling(int fd, uint32_t handle, uint32_t tiling, uint32_t stride)
>
>  	igt_require_intel(fd);
>
> +	if (tiling == I915_TILING_Yf || tiling == I915_TILING_Ys)
> +		tiling = I915_TILING_Y;
> +

This is a bit nasty, breaks tests (or keeps them broken) and more so I 
can't really figure out why would you want to do this?

>  	memset(&st, 0, sizeof(st));
>  	do {
>  		st.handle = handle;
>

Regards,

Tvrtko


More information about the Intel-gfx mailing list