[Intel-gfx] [PATCH 4/7] drm/i915/fbc: inline intel_fbc_can_choose()

Chris Wilson chris at chris-wilson.co.uk
Fri Nov 11 17:31:35 UTC 2016


On Fri, Nov 11, 2016 at 02:57:38PM -0200, Paulo Zanoni wrote:
> It only has two checks now, so it makes sense to just move the code to
> the caller.
> 
> Also take this opportunity to make no_fbc_reason make more sense: now
> we'll only list "no suitable CRTC for FBC" instead of maybe giving a
> reason why the last CRTC we checked was not selected, and we'll more
> consistently set the reason (e.g., if no primary planes are visible).

That seems a reasonable justification for the change.
 
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list