[Intel-gfx] [PATCH igt v3 06/11] igt/gem_exec_parse: make basic-rejected version agnostic

[Matthew Auld]

On 9 November 2016 at 16:15, Robert Bragg <robert at sixbynine.org> wrote:
> This adapts the basic-rejected test to focus on invalid commands that
> will result in an EINVAL errno being returned to userspace even with the
> upcoming version 8 parser change to stop reporting access violations as
> EINVAL errors.
>
> Signed-off-by: Robert Bragg <robert at sixbynine.org>
> ---
>  tests/gem_exec_parse.c | 28 +++++++++++++++++-----------
>  1 file changed, 17 insertions(+), 11 deletions(-)
>
> diff --git a/tests/gem_exec_parse.c b/tests/gem_exec_parse.c
> index 368f30b..63f4efe 100644
> --- a/tests/gem_exec_parse.c
> +++ b/tests/gem_exec_parse.c
> @@ -386,33 +386,39 @@ igt_main
>         }
>
>         igt_subtest("basic-rejected") {
> -               uint32_t arb_on_off[] = {
> -                       MI_ARB_ON_OFF,
> +               uint32_t invalid_cmd[] = {
> +                       (0x7<<29), /* Reserved command type,
> +                                     across all engines */
Maybe make this more clear with something like:

   (INSTR_INVALID_CLIENT << INSTR_CLIENT_SHIFT)

Anyway:
Reviewed-by: Matthew Auld <matthew.auld at intel.com>