[Intel-gfx] [PATCH 6/6] drm/i915: Wipe hang stats as an embedded struct
Mika Kuoppala
mika.kuoppala at linux.intel.com
Tue Nov 15 14:36:36 UTC 2016
Bannable property, banned status, guilty and active counts are
properties of i915_gem_context. Make them so.
Cc: Chris Wilson <chris at chris-wilson.co.uk>
Signed-off-by: Mika Kuoppala <mika.kuoppala at intel.com>
---
drivers/gpu/drm/i915/i915_drv.h | 27 ++++++++-------------------
drivers/gpu/drm/i915/i915_gem.c | 25 ++++++++++++-------------
drivers/gpu/drm/i915/i915_gem_context.c | 12 +++++-------
drivers/gpu/drm/i915/i915_gem_execbuffer.c | 6 ++----
drivers/gpu/drm/i915/i915_gem_request.c | 4 ++--
drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
6 files changed, 30 insertions(+), 46 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 92c5284..fc9d348 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -889,23 +889,6 @@ enum i915_cache_level {
I915_CACHE_WT, /* hsw:gt3e WriteThrough for scanouts */
};
-struct i915_ctx_hang_stats {
- /* This context had batch pending when hang was declared */
- unsigned batch_pending;
-
- /* This context had batch active when hang was declared */
- unsigned batch_active;
-
- bool bannable:1;
-
- /* This context is banned to submit more work */
- bool banned:1;
-
- /* Accumulated score of hangs caused by this context */
- int ban_score;
-};
-
-/* This must match up with the value previously used for execbuf2.rsvd1. */
#define DEFAULT_CONTEXT_HANDLE 0
/**
@@ -935,8 +918,6 @@ struct i915_gem_context {
struct pid *pid;
const char *name;
- struct i915_ctx_hang_stats hang_stats;
-
unsigned long flags;
#define CONTEXT_NO_ZEROMAP BIT(0)
#define CONTEXT_NO_ERROR_CAPTURE BIT(1)
@@ -965,6 +946,14 @@ struct i915_gem_context {
u8 remap_slice;
bool closed:1;
+ bool bannable:1;
+ bool banned:1;
+
+ unsigned int guilty_count; /* guilty of a hang */
+ unsigned int active_count; /* active during hang */
+
+ /* Accumulated score of hangs caused by this context */
+ int ban_score;
};
enum fb_op_origin {
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index f56230f..f78c407 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -2620,15 +2620,13 @@ void *i915_gem_object_pin_map(struct drm_i915_gem_object *obj,
static bool i915_context_is_banned(const struct i915_gem_context *ctx)
{
- const struct i915_ctx_hang_stats *hs = &ctx->hang_stats;
-
- if (hs->banned)
+ if (ctx->banned)
return true;
- if (!hs->bannable)
+ if (!ctx->bannable)
return false;
- if (hs->ban_score >= 40) {
+ if (ctx->ban_score >= 40) {
DRM_DEBUG("context hanging too often, banning!\n");
return true;
}
@@ -2638,20 +2636,21 @@ static bool i915_context_is_banned(const struct i915_gem_context *ctx)
static void i915_gem_request_mark_guilty(struct drm_i915_gem_request *request)
{
- struct i915_ctx_hang_stats *hs = &request->ctx->hang_stats;
+ struct i915_gem_context *ctx = request->ctx;
- hs->ban_score += 10;
+ ctx->ban_score += 10;
- hs->banned = i915_context_is_banned(request->ctx);
- hs->batch_active++;
+ ctx->banned = i915_context_is_banned(request->ctx);
+ ctx->guilty_count++;
DRM_DEBUG_DRIVER("context %s marked guilty (score %d) banned? %s\n",
- request->ctx->name, hs->ban_score, yesno(hs->banned));
+ request->ctx->name, ctx->ban_score,
+ yesno(ctx->banned));
if (!request->file_priv)
return;
- if (hs->banned) {
+ if (ctx->banned) {
request->file_priv->context_bans++;
DRM_DEBUG_DRIVER("client %s has has %d context banned\n",
@@ -2662,9 +2661,9 @@ static void i915_gem_request_mark_guilty(struct drm_i915_gem_request *request)
static void i915_gem_request_mark_innocent(struct drm_i915_gem_request *request)
{
- struct i915_ctx_hang_stats *hs = &request->ctx->hang_stats;
+ struct i915_gem_context *ctx = request->ctx;
- hs->batch_pending++;
+ ctx->active_count++;
}
struct drm_i915_gem_request *
diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c
index 4ddd044..a854eb0 100644
--- a/drivers/gpu/drm/i915/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/i915_gem_context.c
@@ -331,7 +331,7 @@ __create_hw_context(struct drm_device *dev,
* is no remap info, it will be a NOP. */
ctx->remap_slice = ALL_L3_SLICES(dev_priv);
- ctx->hang_stats.bannable = true;
+ ctx->bannable = true;
ctx->ring_size = 4 * PAGE_SIZE;
ctx->desc_template = GEN8_CTX_ADDRESSING_MODE(dev_priv) <<
GEN8_CTX_ADDRESSING_MODE_SHIFT;
@@ -1118,7 +1118,7 @@ int i915_gem_context_getparam_ioctl(struct drm_device *dev, void *data,
args->value = !!(ctx->flags & CONTEXT_NO_ERROR_CAPTURE);
break;
case I915_CONTEXT_PARAM_BANNABLE:
- args->value = ctx->hang_stats.bannable;
+ args->value = ctx->bannable;
break;
default:
ret = -EINVAL;
@@ -1175,7 +1175,7 @@ int i915_gem_context_setparam_ioctl(struct drm_device *dev, void *data,
else if (!capable(CAP_SYS_ADMIN))
ret = -EPERM;
else
- ctx->hang_stats.bannable = args->value;
+ ctx->bannable = args->value;
break;
default:
ret = -EINVAL;
@@ -1191,7 +1191,6 @@ int i915_gem_context_reset_stats_ioctl(struct drm_device *dev,
{
struct drm_i915_private *dev_priv = to_i915(dev);
struct drm_i915_reset_stats *args = data;
- struct i915_ctx_hang_stats *hs;
struct i915_gem_context *ctx;
int ret;
@@ -1210,15 +1209,14 @@ int i915_gem_context_reset_stats_ioctl(struct drm_device *dev,
mutex_unlock(&dev->struct_mutex);
return PTR_ERR(ctx);
}
- hs = &ctx->hang_stats;
if (capable(CAP_SYS_ADMIN))
args->reset_count = i915_reset_count(&dev_priv->gpu_error);
else
args->reset_count = 0;
- args->batch_active = hs->batch_active;
- args->batch_pending = hs->batch_pending;
+ args->batch_active = ctx->guilty_count;
+ args->batch_pending = ctx->active_count;
mutex_unlock(&dev->struct_mutex);
diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
index 21beaf0..1a2ee19 100644
--- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
@@ -1233,18 +1233,16 @@ i915_gem_validate_context(struct drm_device *dev, struct drm_file *file,
{
struct drm_i915_file_private *file_priv = file->driver_priv;
struct i915_gem_context *ctx;
- struct i915_ctx_hang_stats *hs;
ctx = i915_gem_context_lookup(file_priv, ctx_id);
if (IS_ERR(ctx))
return ctx;
- hs = &ctx->hang_stats;
- if (hs->banned) {
+ if (ctx->banned) {
DRM_DEBUG("Client %s banned from submitting (%d:%d)\n",
ctx->name,
file_priv->context_bans,
- hs->ban_score);
+ ctx->ban_score);
return ERR_PTR(-EIO);
}
diff --git a/drivers/gpu/drm/i915/i915_gem_request.c b/drivers/gpu/drm/i915/i915_gem_request.c
index 095c809..3c66798 100644
--- a/drivers/gpu/drm/i915/i915_gem_request.c
+++ b/drivers/gpu/drm/i915/i915_gem_request.c
@@ -205,8 +205,8 @@ static void i915_gem_request_retire(struct drm_i915_gem_request *request)
trace_i915_gem_request_retire(request);
/* Retirement decays the ban score as it is a sign of ctx progress */
- if (request->ctx->hang_stats.ban_score > 0)
- request->ctx->hang_stats.ban_score--;
+ if (request->ctx->ban_score > 0)
+ request->ctx->ban_score--;
spin_lock_irq(&request->engine->timeline->lock);
list_del_init(&request->link);
diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index b8dfa0c..046b6b1 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -1170,7 +1170,7 @@ static void record_request(struct drm_i915_gem_request *request,
struct drm_i915_error_request *erq)
{
erq->context = request->ctx->hw_id;
- erq->ban_score = request->ctx->hang_stats.ban_score;
+ erq->ban_score = request->ctx->ban_score;
erq->seqno = request->global_seqno;
erq->jiffies = request->emitted_jiffies;
erq->head = request->head;
--
2.7.4
More information about the Intel-gfx
mailing list