[Intel-gfx] [PATCH] drm/i915: fix the dequeue logic for single_port_submission context

[Chris Wilson]

On Wed, Nov 16, 2016 at 07:03:42AM +0000, He, Min wrote:
> 
> > -----Original Message-----
> > From: Chris Wilson [mailto:chris at chris-wilson.co.uk]
> > Sent: Wednesday, November 16, 2016 2:52 PM
> > To: He, Min <min.he at intel.com>
> > Cc: intel-gfx at lists.freedesktop.org
> > Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix the dequeue logic for
> > single_port_submission context
> > 
> > On Wed, Nov 16, 2016 at 02:11:16PM +0800, Min He wrote:
> > > For a singl_port_submission context, it can only be submitted to port 0,
> > > and there shouldn't be any other context in port 1 at the same time.
> > > This patch is to implement the correct logic in execlists_dequeue.
> > 
> > There's a simpler fix. (Other than fixing the root cause of the bug in
> > gvt.)
> Can you describe this simpler fix? Thanks.

Instead of changing the flow of the logic, add the break inside the
cannot merge loop. Then you don't have multiple "cannot merge"
questions.

Also, my preferred solution would be to remove the gvt hacks that are
impacting other users.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre