[Intel-gfx] [PATCH] drm/i915: Remove stolen object spam

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Wed Nov 16 12:36:12 UTC 2016


On 16/11/2016 12:26, Chris Wilson wrote:
> We don't spam the debug when we create a normal object, nor when we
> allocate their pages. Yet we do for stolen objects, and since these are
> quite frequently used (at least once per context), the resulting spam
> floods the dmesg in CI.
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/i915_gem_stolen.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c b/drivers/gpu/drm/i915/i915_gem_stolen.c
> index 981796d7618c..55491234beda 100644
> --- a/drivers/gpu/drm/i915/i915_gem_stolen.c
> +++ b/drivers/gpu/drm/i915/i915_gem_stolen.c
> @@ -523,7 +523,6 @@ i915_pages_create_for_stolen(struct drm_device *dev,
>  	struct sg_table *st;
>  	struct scatterlist *sg;
>
> -	DRM_DEBUG_DRIVER("offset=0x%x, size=%d\n", offset, size);
>  	GEM_BUG_ON(offset > dev_priv->ggtt.stolen_size - size);
>
>  	/* We hide that we have no struct page backing our stolen object
> @@ -625,7 +624,6 @@ i915_gem_object_create_stolen(struct drm_device *dev, u32 size)
>  	if (!drm_mm_initialized(&dev_priv->mm.stolen))
>  		return NULL;
>
> -	DRM_DEBUG_KMS("creating stolen object: size=%x\n", size);
>  	if (size == 0)
>  		return NULL;
>
>

Yay!

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko


More information about the Intel-gfx mailing list