[Intel-gfx] [PATCH 2/2] drm/i915/guc: Split hw submission for replay after GPU reset

[Chris Wilson]

On Wed, Nov 16, 2016 at 12:53:07PM +0000, Tvrtko Ursulin wrote:
> On 16/11/2016 12:20, Chris Wilson wrote:
> >@@ -1538,8 +1541,7 @@ int i915_guc_submission_enable(struct drm_i915_private *dev_priv)
> > 		list_for_each_entry(request,
> > 				    &engine->timeline->requests, link) {
> > 			client->wq_rsvd += sizeof(struct guc_wq_item);
> >-			if (i915_sw_fence_done(&request->submit))
> >-				i915_guc_submit(request);
> >+			__i915_guc_submit(request);
> > 		}
> > 	}
> >
> >
> 
> Sounds believable.
> 
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> I am just lost at the moment on where the equivalent execlist
> restart is in the code?

In execlists, we track wants on hw using the execlist_port[] and so we
just submit that pair when replaying.

Hmm, which adds a nice little oddity to the GuC, I was kick starting it
by writing to the ELSP... Mwhahaha :)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre