[Intel-gfx] [PATCH v3] drm/i915: fix the dequeue logic for single_port_submission context

[Zhenyu Wang]

On 2016.11.16 22:05:04 +0800, Min He wrote:
> For a singl_port_submission context, it can only be submitted to port 0,
> and there shouldn't be any other context in port 1 at the same time. This
> is required by GVT-g context to have an opportunity to save/restore some
> non-hw context render registers.
> This patch is to implement the correct logic in execlists_dequeue.
> 
> v2: optimized code by following Chris's advice, and added more comments to
> explain the patch.
> v3: followed the coding style.
> 
> Signed-off-by: Min He <min.he at intel.com>
> Signed-off-by: Zhenyu Wang <zhenyuw at linux.intel.com>
> ---

Hi, Min, like Daniel said not need to add my s-o-b.

>  drivers/gpu/drm/i915/intel_lrc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index f50feaa..b2c0d50 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -499,7 +499,8 @@ static void execlists_dequeue(struct intel_engine_cs *engine)
>  			 * context (even though a different request) to
>  			 * the second port.
>  			 */
> -			if (ctx_single_port_submission(cursor->ctx))
> +			if (ctx_single_port_submission(last->ctx) ||
> +			    ctx_single_port_submission(cursor->ctx))
>  				break;
>  
>  			GEM_BUG_ON(last->ctx == cursor->ctx);
> -- 
> 1.9.1
>

Reviewed-by: Zhenyu Wang <zhenyuw at linux.intel.com>

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20161117/c9e6e6ec/attachment.sig>