[Intel-gfx] [i-g-t PATCH v7 4/5] igt/kms_flip: Use new igt_spin_batch

Chris Wilson chris at chris-wilson.co.uk
Thu Nov 17 10:25:59 UTC 2016


On Wed, Nov 16, 2016 at 11:18:03PM +0200, Abdiel Janulgue wrote:
>  	if (o->flags & TEST_WITH_DUMMY_BCS)
> -		emit_dummy_load__bcs(o, 1);
> +		igt_spin_batch_wait(drm_fd, NSEC_PER_SEC, I915_EXEC_BLT,
> +				    o->fb_info[o->current_fb_id].gem_handle);

This is counterintuitive for the purpose of testing flips. We don't want
the fb to be idle, which is what will happen if we wait upon it.

We want to set off a spinner that will only complete once we have queued
the flip. We can eliminate the 1s dummy load by being explicit in the
ordering.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list