[Intel-gfx] [i-g-t PATCH v7 5/5] igt/kms_busy.c: Use new igt_spin_batch

Abdiel Janulgue abdiel.janulgue at linux.intel.com
Thu Nov 17 10:29:35 UTC 2016



On 17.11.2016 12:27, Chris Wilson wrote:
> On Wed, Nov 16, 2016 at 11:18:04PM +0200, Abdiel Janulgue wrote:
>> @@ -179,7 +111,8 @@ static void flip_to_fb(igt_display_t *dpy, int pipe,
>>  	}
>>  	igt_assert_f(nanosleep(&tv, NULL) == -1,
>>  		     "flip to %s blocked waiting for busy fb", name);
>> -	finish_fb_busy(batch, 2*TIMEOUT);
>> +	finish_fb_busy(t->batch, 2*TIMEOUT);
> 
> As you didn't adjust finish_fb_busy, this is a double munmap.
> 
> finish_fb_busy() is now just a sleep to allow the worker to do its
> things. That could be tidied up.
> -Chris

Hey thanks for the review! I'll follow up asap!

-Abdiel

> 


More information about the Intel-gfx mailing list