[Intel-gfx] [PATCH v2 3/4] drm/i915: Mark all non-vma being inserted into the address spaces

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Thu Nov 17 13:31:54 UTC 2016


On to, 2016-11-17 at 12:08 +0000, Chris Wilson wrote:
> We need to distinguish between full i915_vma structs and simple
> drm_mm_nodes when considering eviction (i.e. we must be careful not to
> treat a mere drm_mm_node as a much larger i915_vma causing memory
> corruption, if we are lucky). To do this, color these not-a-vma with -1
> (UNCOLORED).
> 

I might opt for I915_MM_UNCOLORED, just to stay on the safe side as
this is in a .h file.

> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

You may or may not want to have it in i915_gem_stolen.c for
completeness.

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list