[Intel-gfx] [PATCH] drm/i915: add i915_address_space_fini

[Chris Wilson]

On Thu, Nov 17, 2016 at 08:53:15PM +0000, Matthew Auld wrote:
> We already have an i915_address_space_init, so for symmetry we should
> also have a _fini, plus we already open code it twice. This then also
> fixes a bug where we leak the timeline for the ggtt vm.
> 
> v2: don't forget about the struct_mutex for the ggtt path.
> 
> Fixes: 80b204bce8f2 ("drm/i915: Enable multiple timelines")
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Matthew Auld <matthew.auld at intel.com>

> @@ -2279,7 +2286,7 @@ i915_ppgtt_create(struct drm_i915_private *dev_priv,
>  	return ppgtt;
>  }
>  
> -void  i915_ppgtt_release(struct kref *kref)
> +void i915_ppgtt_release(struct kref *kref)

Finally!
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

I'm sure the rest of the patch is just as good ;)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre