[Intel-gfx] [[PATCH ddx]] intel: Adding Marketing names for Skylake, Kabylake and Apollolake/Broxton.

Thu Nov 17 21:23:17 UTC 2016

On Thu, Nov 17, 2016 at 09:03:42PM +0000, Vivi, Rodrigo wrote:
> On Thu, 2016-11-17 at 19:35 +0000, Chris Wilson wrote:
> > On Thu, Nov 17, 2016 at 11:06:54AM -0800, Rodrigo Vivi wrote:
> > > On Thu, Nov 17, 2016 at 10:53:04AM +0200, David Weinehall wrote:
> > > > On Tue, Nov 15, 2016 at 02:21:01PM -0800, Rodrigo Vivi wrote:
> > > > > This commit adding all known marketing names for latest gen9 platforms.
> > > > > 
> > > > > Cc: Chris Wilson <chris at chris-wilson.co.uk>
> > > > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> > > > > ---
> > > > >  README             |  2 +-
> > > > >  man/intel.man      |  2 +-
> > > > >  src/intel_module.c | 29 ++++++++++++++++++++++++++++-
> > > > >  3 files changed, 30 insertions(+), 3 deletions(-)
> > > > > 
> > > > > diff --git a/README b/README
> > > > > index cf4d88d..e58477d 100644
> > > > > --- a/README
> > > > > +++ b/README
> > > > > @@ -15,7 +15,7 @@ Intel graphics chipsets including:
> > > > >  	G/Q33,G/Q35,G41,G/Q43,G/GM/Q45
> > > > >  	PineView-M (Atom N400 series)
> > > > >  	PineView-D (Atom D400/D500 series)
> > > > > -	Intel(R) HD Graphics: 2000-6000,
> > > > > +	Intel(R) HD Graphics: 500-6000/P530/P555/P580,
> > > > >  	Intel(R) Iris(TM) Graphics: 5100/6100, and
> > > > >  	Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
> > > > >  
> > > > > diff --git a/man/intel.man b/man/intel.man
> > > > > index 8da496e..16cc5d9 100644
> > > > > --- a/man/intel.man
> > > > > +++ b/man/intel.man
> > > > > @@ -27,7 +27,7 @@ supports the i810, i810-DC100, i810e, i815, i830M, 845G, 852GM, 855GM,
> > > > >  865G, 915G, 915GM, 945G, 945GM, 965G, 965Q, 946GZ, 965GM, 945GME,
> > > > >  G33, Q33, Q35, G35, GM45, G45, Q45, G43, G41 chipsets, Pineview-M in
> > > > >  Atom N400 series, Pineview-D in Atom D400/D500 series,
> > > > > -Intel(R) HD Graphics: 2000-6000,
> > > > > +Intel(R) HD Graphics: 500-6000/P530/P555/P580,
> > > > >  Intel(R) Iris(TM) Graphics: 5100/6100, and
> > > > >  Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
> > > > >  
> > > > > diff --git a/src/intel_module.c b/src/intel_module.c
> > > > > index e443c9e..86b4aae 100644
> > > > > --- a/src/intel_module.c
> > > > > +++ b/src/intel_module.c
> > > > > @@ -272,6 +272,33 @@ static const SymTabRec intel_chipsets[] = {
> > > > >  	{0x22b2, "HD Graphics"},
> > > > >  	{0x22b3, "HD Graphics"},
> > > > >  
> > > > > +	/* Skylake */
> > > > > +	{0x1902, "HD Graphics 510"},
> > > > > +	{0x1906, "HD Graphics 510"},
> > > > > +	{0x190B, "HD Graphics 510"},
> > > > > +	{0x1912, "HD Graphics 530"},
> > > > > +	{0x1916, "HD Graphics 520"},
> > > > > +	{0x191B, "HD Graphics 530"},
> > > > > +	{0x191D, "HD Graphics P530"},
> > > > > +	{0x191E, "HD Graphics 515"},
> > > > > +	{0x1921, "HD Graphics 520"},
> > > > > +	{0x1926, "Iris Graphics 540"},
> > > > > +	{0x1927, "Iris Graphics 550"},
> > > > > +	{0x192B, "Iris Graphics 555"},
> > > > > +	{0x192D, "Iris Graphics P555"},
> > > > > +	{0x1932, "Iris Pro Graphics 580"},
> > > > > +	{0x193A, "Iris Pro Graphics P580"},
> > > > > +	{0x193B, "Iris Pro Graphics 580"},
> > > > > +	{0x193D, "Iris Pro Graphics P580"},
> > > > > +
> > > > > +	/* Broxton (Apollolake) */
> > > > > +	{0x5A84, "HD Graphics 505"},
> > > > > +	{0x5A85, "HD Graphics 500"},
> > > > > +
> > > > > +	/* Kabylake */
> > > > > +	{0x5916, "HD Graphics 620"},
> > > > > +	{0x591E, "HD Graphics 615"},
> > > > > +
> > > > >  	/* When adding new identifiers, also update:
> > > > >  	 * 1. intel_identify()
> > > > >  	 * 2. man/intel.man
> > > > > @@ -465,7 +492,7 @@ static void intel_identify(int flags)
> > > > >  	if (unique != stack)
> > > > >  		free(unique);
> > > > >  
> > > > > -	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 2000-6000\n");
> > > > > +	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 500-6000/P530/P555/P580\n");
> > > > >  	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Graphics: 5100, 6100\n");
> > > > >  	xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Pro Graphics: 5200, 6200, P6300\n");
> > > > 
> > > > You missed the Iris & Iris Pro models.
> > > 
> > > Thanks
> > > 
> > > > 
> > > > Also, might it make sense to use 5xx, P5xx instead?
> > > 
> > > What about ont those generic lists we just kill all numbers and let just:
> > > "
> > >    Intel(R) HD Graphics.
> > >    Intel(R) Iris(TM) Graphics.
> > >    Intel(R) Iris(TM) Pro Graphics.
> > > '
> > > ?
> > > 
> > > Chris?
> > 
> > Seems reasonable, and as demonstrated in the past simply listing
> > everything becomes unwieldy, if not unfathomable, quickly.
> > 
> > I honestly don't think the listing here is the primary source for
> > compatibility info
> 
> agree
> 
> >  (since to get here means that the driver recognised
> > the chipset anyway).
> 
> If it is already recognized at this intel_identify point, is it possible
> to grab the device id and than run on that list and only print the know
> market name?
> or that is better to let there on detect function?
> 
> 
> >  For that we can throw into the catch all case in
> > intel_identify().
> 
> What do you mean? throw all this list away? or really list everyone here
> on intel_identify but remove the numbers from other plances?

Sorry, not intel_identify(), but intel_detect_chipset() prints the
exact marketing name if known. It's what to print when it is unknown
that worries me most.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre