[Intel-gfx] [PATCH v5] drm/i915: Be more careful to drop the GT wakeref

[Chris Wilson]

On Fri, Nov 18, 2016 at 01:22:11PM +0200, Joonas Lahtinen wrote:
> On ti, 2016-11-15 at 16:46 +0000, Chris Wilson wrote:
> > @@ -218,7 +218,12 @@ static void i915_gem_request_retire(struct drm_i915_gem_request *request)
> >  	 */
> >  	list_del(&request->ring_link);
> >  	request->ring->last_retired_head = request->postfix;
> > -	request->i915->gt.active_requests--;
> > +	if (!--request->i915->gt.active_requests) {
> 
> BUG_ON(!request->i915->gt.active_requests) at the top?

Yup, that would be a nasty bug to catch.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre