[Intel-gfx] [PATCH 3/3] drm/i915: optimise intel_runtime_pm_{get, put}

[kbuild test robot]

Hi David,

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20161117]
[cannot apply to v4.9-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/David-Weinehall/Resume-time-optimisation/20161118-181301
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-x009-201646 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/i915/intel_runtime_pm.c: In function 'intel_runtime_pm_get_if_in_use':
>> drivers/gpu/drm/i915/intel_runtime_pm.c:2660:3: warning: 'return' with no value, in function returning non-void [-Wreturn-type]
      return;
      ^~~~~~
   drivers/gpu/drm/i915/intel_runtime_pm.c:2654:6: note: declared here
    bool intel_runtime_pm_get_if_in_use(struct drm_i915_private *dev_priv)
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/return +2660 drivers/gpu/drm/i915/intel_runtime_pm.c

  2644	/**
  2645	 * intel_runtime_pm_get_if_in_use - grab a runtime pm reference if device in use
  2646	 * @dev_priv: i915 device instance
  2647	 *
  2648	 * This function grabs a device-level runtime pm reference if the device is
  2649	 * already in use and ensures that it is powered up.
  2650	 *
  2651	 * Any runtime pm reference obtained by this function must have a symmetric
  2652	 * call to intel_runtime_pm_put() to release the reference again.
  2653	 */
  2654	bool intel_runtime_pm_get_if_in_use(struct drm_i915_private *dev_priv)
  2655	{
  2656		struct pci_dev *pdev = dev_priv->drm.pdev;
  2657		struct device *kdev = &pdev->dev;
  2658	
  2659		if (atomic_inc_not_zero(&dev_priv->pm.wakeref_count))
> 2660			return;
  2661	
  2662		if (IS_ENABLED(CONFIG_PM)) {
  2663			int ret = pm_runtime_get_if_in_use(kdev);
  2664	
  2665			/*
  2666			 * In cases runtime PM is disabled by the RPM core and we get
  2667			 * an -EINVAL return value we are not supposed to call this
  2668			 * function, since the power state is undefined. This applies

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 30141 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20161118/0ae926e4/attachment-0001.gz>