[Intel-gfx] [PATCH] drm/i915: Do not log disabled planes in pipe config

Ville Syrjälä ville.syrjala at linux.intel.com
Fri Nov 18 14:19:59 UTC 2016


On Fri, Nov 18, 2016 at 03:13:14PM +0100, Maarten Lankhorst wrote:
> Op 18-11-16 om 12:40 schreef Tvrtko Ursulin:
> > From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> >
> > It just says "plane X disabled" which does not seem very useful.
> >
> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> > Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Could we remove plane dumping altogether? It's not safe to do so in the way done by this function, and we could add missing things in intel_plane_atomic_calc_changes.

Yeah, might make sense to dump that stuff only from some plane code. And
we should probably take a good look at Rob Clark's new state dumping stuff
for that, so that we'll get it in some decently standardized format.

I must admit that I didn't take a very good look at Rob's stuff, but
maybe he already added the dumps to some useful places, and all we'd
have to do is expand the dumps with our own derived plane state...

-- 
Ville Syrjälä
Intel OTC


More information about the Intel-gfx mailing list