[Intel-gfx] [RFC PATCH] drm/i915: replace platform flags with a platform enum

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Fri Nov 18 14:27:37 UTC 2016


On 18/11/2016 14:20, Jani Nikula wrote:
> The platform flags in device info are (mostly) mutually
> exclusive. Replace the flags with an enum. Add the platform enum also
> for platforms that previously didn't have a flag, and give them codename
> logging in dmesg.

It just saddens me a bit that it prevents the compiler optimisation of 
our IS_THIS || IS_THAT || IS_TAT ugliness. :I On the basis on that I 
cannot quite make myself to support it, although it conceptually does 
make more sense.

Regards,

Tvrtko


More information about the Intel-gfx mailing list