[Intel-gfx] [PATCH] drm/i915: Do not log disabled planes in pipe config

[Maarten Lankhorst]

Op 21-11-16 om 11:50 schreef Tvrtko Ursulin:
>
> On 18/11/2016 14:19, Ville Syrjälä wrote:
>> On Fri, Nov 18, 2016 at 03:13:14PM +0100, Maarten Lankhorst wrote:
>>> Op 18-11-16 om 12:40 schreef Tvrtko Ursulin:
>>>> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>>>>
>>>> It just says "plane X disabled" which does not seem very useful.
>>>>
>>>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>>>> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>>>> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
>>> Could we remove plane dumping altogether? It's not safe to do so in the way done by this function, and we could add missing things in intel_plane_atomic_calc_changes.
>>
>> Yeah, might make sense to dump that stuff only from some plane code. And
>> we should probably take a good look at Rob Clark's new state dumping stuff
>> for that, so that we'll get it in some decently standardized format.
>>
>> I must admit that I didn't take a very good look at Rob's stuff, but
>> maybe he already added the dumps to some useful places, and all we'd
>> have to do is expand the dumps with our own derived plane state...
>
> Shall I leave it with you guys then? The most I would feel confident in this area is to submit a patch which removes the plane debug from intel_dump_pipe_config if that is broken. But not sure how useful would that be without this other work you are discussing. 
Intel plane dumping is broken regardless, so feel I think it's good to submit a patch to nuke it. :)