[Intel-gfx] [PATCH 4/4] drm/i915/lspcon: Remove unused force change mode parameter

[Sharma, Shashank]

The reason why I kept the force function was, that during debug phase, I 
saw a need to change LSPCON mode.

Also, in future, if we need to provide an IOCTL/control to userspace, to 
change lspcon mode, force may be required

to differentiate the path from user/kernel space.

But in any case: Reviewed-by: Shashank Sharma <shashank.sharma at intel.com>


Regards

Shashank

On 11/22/2016 12:45 AM, Imre Deak wrote:
> All callers asked for a forced change but the function ignored this
> parameter. It doesn't seem to be necessary to force the change in any
> case so let's just remove the parameter.
>
> Cc: Shashank Sharma <shashank.sharma at intel.com>
> Signed-off-by: Imre Deak <imre.deak at intel.com>
> ---
>   drivers/gpu/drm/i915/intel_lspcon.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lspcon.c b/drivers/gpu/drm/i915/intel_lspcon.c
> index 281127d..f6d4e69 100644
> --- a/drivers/gpu/drm/i915/intel_lspcon.c
> +++ b/drivers/gpu/drm/i915/intel_lspcon.c
> @@ -87,7 +87,7 @@ static enum drm_lspcon_mode lspcon_wait_mode(struct intel_lspcon *lspcon,
>   }
>   
>   static int lspcon_change_mode(struct intel_lspcon *lspcon,
> -	enum drm_lspcon_mode mode, bool force)
> +			      enum drm_lspcon_mode mode)
>   {
>   	int err;
>   	enum drm_lspcon_mode current_mode;
> @@ -202,7 +202,7 @@ void lspcon_resume(struct intel_lspcon *lspcon)
>   	if (lspcon_wait_mode(lspcon, expected_mode) == DRM_LSPCON_MODE_PCON)
>   		return;
>   
> -	if (lspcon_change_mode(lspcon, DRM_LSPCON_MODE_PCON, true))
> +	if (lspcon_change_mode(lspcon, DRM_LSPCON_MODE_PCON))
>   		DRM_ERROR("LSPCON resume failed\n");
>   	else
>   		DRM_DEBUG_KMS("LSPCON resume success\n");
> @@ -239,8 +239,7 @@ bool lspcon_init(struct intel_digital_port *intel_dig_port)
>   	* 2.0 sinks.
>   	*/
>   	if (lspcon->active && lspcon->mode != DRM_LSPCON_MODE_PCON) {
> -		if (lspcon_change_mode(lspcon, DRM_LSPCON_MODE_PCON,
> -			true) < 0) {
> +		if (lspcon_change_mode(lspcon, DRM_LSPCON_MODE_PCON) < 0) {
>   			DRM_ERROR("LSPCON mode change to PCON failed\n");
>   			return false;
>   		}