[Intel-gfx] [PATCH] drm/i915/guc: Always initialize action_lock

Chris Wilson chris at chris-wilson.co.uk
Tue Nov 22 17:05:32 UTC 2016


On Tue, Nov 22, 2016 at 05:22:47PM +0100, Arkadiusz Hiler wrote:
> Action lock is not being initialized if the GuC submission is disabled
> (i.e. i915.guc_submission=0).
> 
> host2guc_action(), which uses the action_lock can be used for
> non-submission purposes, e.g. triggering HuC authentication.
> 
> Moving action_lock initialization before enablement check will allow us
> to use the host2guc_action no matter whether submission is enabled or
> not.
> 
> Cc: Anusha Srivatsa <anusha.srivatsa at intel.com>
> Cc: Jeff McGee <jeff.mcgee at intel.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>

Seems like you want to split uc_send(), uc_recv() out of
i915_guc_submission.c
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list