[Intel-gfx] [PATCH] drm/i915: i915_gem_alloc_context_obj can be static

[Chris Wilson]

On Wed, Nov 23, 2016 at 10:20:34AM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> It has only one call site from the same file.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.h         | 2 --
>  drivers/gpu/drm/i915/i915_gem_context.c | 2 +-
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 970e50bf9884..c44f2410f10f 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -3342,8 +3342,6 @@ struct i915_vma *
>  i915_gem_context_pin_legacy(struct i915_gem_context *ctx,
>  			    unsigned int flags);
>  void i915_gem_context_free(struct kref *ctx_ref);
> -struct drm_i915_gem_object *
> -i915_gem_alloc_context_obj(struct drm_device *dev, size_t size);
>  struct i915_gem_context *
>  i915_gem_context_create_gvt(struct drm_device *dev);
>  
> diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c
> index f82936a2fcce..7c1364801cfe 100644
> --- a/drivers/gpu/drm/i915/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/i915_gem_context.c
> @@ -166,7 +166,7 @@ void i915_gem_context_free(struct kref *ctx_ref)
>  	kfree(ctx);
>  }
>  
> -struct drm_i915_gem_object *
> +static struct drm_i915_gem_object *
>  i915_gem_alloc_context_obj(struct drm_device *dev, size_t size)

Could we shrink it a bit so the caller fits onto one line?
alloc_context_obj?

And size_t is not the right type (u64 is overkill but matches the
interface and gcc should be fine).

Other than that, have a preemptive
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre