[Intel-gfx] [PATCH 0/4] GuC code reorganization

[Chris Wilson]

On Thu, Nov 24, 2016 at 12:30:39PM +0100, Arkadiusz Hiler wrote:
> With HuC being imminent we could benefit from some code reorganization.
> There will be more uC than just GuC so we should name files accordingly.
> 
> There is also need to use host2guc_*() family of functions, which are currently
> limited to submission only.
> 
> Arkadiusz Hiler (4):
>   drm/i915: Rename intel_guc.h to intel_uc.h

Ok.
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

>   drm/i915/guc: Move host2guc_*() to intel_uc.c

host2guc_action() is generic, but host2guc_allocate_doorbell() is not.

host2guc is an unconventional prefix, it should be intel_uc_<verb> to
match its new location. (I like intel_uc_send / intel_uc_recv but I'm
just an old fuddy-duddy.)

>   drm/i915/guc: Init action_lock in the loader

Where's intel_uc_init() ? The lock is for the uc sidechannel, it should
only really be used in intel_uc.c for intel_uc_send / intel_uc_recb.

>   drm/i915/guc: Remove spurious include

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre