[Intel-gfx] [alsa-devel] [RFC PATCH v3 1/7] drm/i915: setup bridge for HDMI LPE audio driver

Ville Syrjälä ville.syrjala at linux.intel.com
Mon Nov 28 13:43:07 UTC 2016


On Sun, Nov 27, 2016 at 12:20:30PM -0600, Pierre-Louis Bossart wrote:
> On 11/24/16 7:31 AM, Ville Syrjälä wrote:
> >> +static void lpe_audio_irq_unmask(struct irq_data *d)
> >> +{
> >> +	struct drm_device *dev = d->chip_data;
> >> +	struct drm_i915_private *dev_priv = to_i915(dev);
> >> +	unsigned long irqflags;
> >> +	u32 val = (I915_LPE_PIPE_A_INTERRUPT |
> >> +		I915_LPE_PIPE_B_INTERRUPT |
> >> +		I915_LPE_PIPE_C_INTERRUPT);
> > No pipe C on vlv.
> 
> Yes but does it hurt to set this bit? If the hardware is not present 
> then there is no side effect, is there?

I'm too lazy to check if the bit is already taken.

-- 
Ville Syrjälä
Intel OTC


More information about the Intel-gfx mailing list