[Intel-gfx] [PATCH v2] drm/i915: Pass dev_priv to intel_setup_outputs()
Daniel Vetter
daniel at ffwll.ch
Tue Nov 29 09:09:13 UTC 2016
On Thu, Nov 24, 2016 at 11:44:37AM +0800, kbuild test robot wrote:
> Hi Ander,
>
> [auto build test WARNING on drm-intel/for-linux-next]
> [also build test WARNING on next-20161123]
> [cannot apply to v4.9-rc6]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Ander-Conselvan-de-Oliveira/drm-i915-Pass-dev_priv-to-intel_setup_outputs/20161124-093455
> base: git://anongit.freedesktop.org/drm-intel for-linux-next
> reproduce: make htmldocs
>
> All warnings (new ones prefixed by >>):
>
> make[3]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule.
> include/linux/init.h:1: warning: no structured comments found
> include/linux/workqueue.h:392: warning: No description found for parameter '...'
> include/linux/workqueue.h:392: warning: Excess function parameter 'args' description in 'alloc_workqueue'
> include/linux/workqueue.h:413: warning: No description found for parameter '...'
> include/linux/workqueue.h:413: warning: Excess function parameter 'args' description in 'alloc_ordered_workqueue'
> include/linux/kthread.h:26: warning: No description found for parameter '...'
> kernel/sys.c:1: warning: no structured comments found
> drivers/dma-buf/seqno-fence.c:1: warning: no structured comments found
> include/sound/core.h:324: warning: No description found for parameter '...'
> include/sound/core.h:335: warning: No description found for parameter '...'
> include/sound/core.h:388: warning: No description found for parameter '...'
> include/drm/drm_drv.h:295: warning: Incorrect use of kernel-doc format: * Hook for allocating the GEM object struct, for use by core
> include/drm/drm_drv.h:407: warning: No description found for parameter 'load'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'firstopen'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'open'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'preclose'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'postclose'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'lastclose'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'unload'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'dma_ioctl'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'dma_quiescent'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'context_dtor'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'set_busid'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_handler'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_preinstall'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_postinstall'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_uninstall'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'debugfs_init'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'debugfs_cleanup'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_open_object'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_close_object'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_create_object'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'prime_handle_to_fd'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'prime_fd_to_handle'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_export'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_import'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_pin'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_unpin'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_res_obj'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_get_sg_table'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_import_sg_table'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_vmap'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_vunmap'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_mmap'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'vgaarb_irq'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_vm_ops'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'major'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'minor'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'patchlevel'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'name'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'desc'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'date'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'driver_features'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'dev_priv_size'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'ioctls'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'num_ioctls'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'fops'
> include/drm/drm_drv.h:407: warning: No description found for parameter 'legacy_dev_list'
> >> drivers/gpu/drm/i915/intel_psr.c:822: warning: No description found for parameter 'dev_priv'
> >> drivers/gpu/drm/i915/intel_psr.c:822: warning: Excess function parameter 'dev' description in 'intel_psr_init'
I also just spotted these. Please run
make DOCBOOKS="" htmldocs
and fix up the fallout.
Thanks, Daniel
> drivers/gpu/drm/i915/intel_psr.c:823: warning: No description found for parameter 'dev_priv'
> drivers/gpu/drm/i915/intel_psr.c:823: warning: Excess function parameter 'dev' description in 'intel_psr_init'
> include/media/media-entity.h:1054: warning: No description found for parameter '...'
> include/net/mac80211.h:3207: ERROR: Unexpected indentation.
> include/net/mac80211.h:3210: WARNING: Block quote ends without a blank line; unexpected unindent.
> include/net/mac80211.h:3212: ERROR: Unexpected indentation.
> include/net/mac80211.h:3213: WARNING: Block quote ends without a blank line; unexpected unindent.
> include/net/mac80211.h:1772: ERROR: Unexpected indentation.
> include/net/mac80211.h:1776: WARNING: Block quote ends without a blank line; unexpected unindent.
> kernel/sched/fair.c:7259: WARNING: Inline emphasis start-string without end-string.
> kernel/time/timer.c:1240: ERROR: Unexpected indentation.
> kernel/time/timer.c:1242: ERROR: Unexpected indentation.
> kernel/time/timer.c:1243: WARNING: Block quote ends without a blank line; unexpected unindent.
> include/linux/wait.h:121: WARNING: Block quote ends without a blank line; unexpected unindent.
> include/linux/wait.h:124: ERROR: Unexpected indentation.
> include/linux/wait.h:126: WARNING: Block quote ends without a blank line; unexpected unindent.
> kernel/time/hrtimer.c:1021: WARNING: Block quote ends without a blank line; unexpected unindent.
> kernel/signal.c:317: WARNING: Inline literal start-string without end-string.
> drivers/base/firmware_class.c:1348: WARNING: Bullet list ends without a blank line; unexpected unindent.
> drivers/message/fusion/mptbase.c:5054: WARNING: Definition list ends without a blank line; unexpected unindent.
> drivers/tty/serial/serial_core.c:1893: WARNING: Definition list ends without a blank line; unexpected unindent.
> include/linux/spi/spi.h:369: ERROR: Unexpected indentation.
> WARNING: dvipng command 'dvipng' cannot be run (needed for math display), check the imgmath_dvipng setting
>
> vim +/dev_priv +822 drivers/gpu/drm/i915/intel_psr.c
>
> 995d3047 Rodrigo Vivi 2014-11-19 806
> 0bc12bcb Rodrigo Vivi 2014-11-14 807 if (!dev_priv->psr.active && !dev_priv->psr.busy_frontbuffer_bits)
> d0ac896a Rodrigo Vivi 2015-11-11 808 if (!work_busy(&dev_priv->psr.work.work))
> 0bc12bcb Rodrigo Vivi 2014-11-14 809 schedule_delayed_work(&dev_priv->psr.work,
> 20bb97fe Rodrigo Vivi 2015-11-11 810 msecs_to_jiffies(100));
> 0bc12bcb Rodrigo Vivi 2014-11-14 811 mutex_unlock(&dev_priv->psr.lock);
> 0bc12bcb Rodrigo Vivi 2014-11-14 812 }
> 0bc12bcb Rodrigo Vivi 2014-11-14 813
> b2b89f55 Rodrigo Vivi 2014-11-14 814 /**
> b2b89f55 Rodrigo Vivi 2014-11-14 815 * intel_psr_init - Init basic PSR work and mutex.
> b2b89f55 Rodrigo Vivi 2014-11-14 816 * @dev: DRM device
> b2b89f55 Rodrigo Vivi 2014-11-14 817 *
> b2b89f55 Rodrigo Vivi 2014-11-14 818 * This function is called only once at driver load to initialize basic
> b2b89f55 Rodrigo Vivi 2014-11-14 819 * PSR stuff.
> b2b89f55 Rodrigo Vivi 2014-11-14 820 */
> 91ed48bf Ander Conselvan de Oliveira 2016-11-23 821 void intel_psr_init(struct drm_i915_private *dev_priv)
> 0bc12bcb Rodrigo Vivi 2014-11-14 @822 {
> 443a389f Ville Syrjälä 2015-11-11 823 dev_priv->psr_mmio_base = IS_HASWELL(dev_priv) ?
> 443a389f Ville Syrjälä 2015-11-11 824 HSW_EDP_PSR_BASE : BDW_EDP_PSR_BASE;
> 443a389f Ville Syrjälä 2015-11-11 825
> d94d6e87 Rodrigo Vivi 2016-02-12 826 /* Per platform default */
> d94d6e87 Rodrigo Vivi 2016-02-12 827 if (i915.enable_psr == -1) {
> 8652744b Tvrtko Ursulin 2016-10-13 828 if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
> a38c274f Rodrigo Vivi 2016-02-12 829 i915.enable_psr = 1;
> a38c274f Rodrigo Vivi 2016-02-12 830 else
>
> :::::: The code at line 822 was first introduced by commit
> :::::: 0bc12bcb1b9686d7011f16410ba17ed0740167c3 drm/i915: Introduce intel_psr.c
>
> :::::: TO: Rodrigo Vivi <rodrigo.vivi at intel.com>
> :::::: CC: Daniel Vetter <daniel.vetter at ffwll.ch>
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
More information about the Intel-gfx
mailing list