[Intel-gfx] [PATCH 2/2] Revert "drm/i915/execlists: Use a local lock for dfs_link access"

Chris Wilson chris at chris-wilson.co.uk
Tue Nov 29 09:22:04 UTC 2016


On Tue, Nov 29, 2016 at 08:51:02AM +0000, Tvrtko Ursulin wrote:
> 
> On 28/11/2016 14:36, Chris Wilson wrote:
> >This reverts commit 27745e829a5c ("drm/i915/execlists: Use a local lock
> >for dfs_link access") as the struct_mutex was required to prevent
> >concurrent retiring and freeing, now restored in the previous patch.
> >
> >Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> >Cc: David Weinehall <david.weinehall at linux.intel.com>
> >Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Pushed this pair. Revisiting the struct_mutex requirement here is a
possibility. Just need to remember the issue with cross-engine retires.
Will also be a factor in lifting this, or a similar, scheme to dma-buf.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list