[Intel-gfx] [PATCH] drm/i915: Just clear the mmiodebug before a register access

Chris Wilson chris at chris-wilson.co.uk
Mon Oct 3 10:17:29 UTC 2016


On Mon, Oct 03, 2016 at 01:09:31PM +0300, Mika Kuoppala wrote:
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> 
> > When we enable the per-register access mmiodebug, it is to detect which
> > access is illegal. Reporting on earlier untraced access outside of the
> > mmiodebug does not help debugging (as the suspicion is immediately put
> > upon the current register which is not at fault)!
> >
> 
> I think the original intent here was that if the unclaimed access was
> before driver register access, it would be sometimes possible to assess
> the real culprit by understanding what happened before this moment.

We have warnings elsewhere to catch this, and since we provide no debug
output in these cases flagging an error to the user is just noise for
them *and* us.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list