[Intel-gfx] [PATCH v2 13/22] drm/i915: Update reset path to fix incomplete requests

Chris Wilson chris at chris-wilson.co.uk
Mon Oct 3 12:56:06 UTC 2016


On Mon, Oct 03, 2016 at 01:44:14PM +0100, Tvrtko Ursulin wrote:
> >+static void i915_gem_cleanup_engine(struct intel_engine_cs *engine)
> 
> I am aware this is a late comment, but wanted to say that the name
> above is not ideal since we have both i915_gem_cleanup_engines and
> dev_priv->gt.cleanup_engine which do completely different type of
> thing than this.

A long time ago we were heading to a world where
dev_priv->gt.cleanup_engines was replaced by a vfunc within the engine
itself. Not a good excuse, but one day the naming will resolve itself.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list