[Intel-gfx] [PATCH 2/2] drm/i915: Sort DEV_INFO_FOR_EACH_FLAG

Chris Wilson chris at chris-wilson.co.uk
Tue Oct 4 13:32:03 UTC 2016


On Tue, Oct 04, 2016 at 03:42:58PM +0300, Joonas Lahtinen wrote:
> Sort DEV_INFO_FOR_EACH_FLAG to alphabetical order (except is_*).
> 
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Ok. Looks like it should be easier to read.
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Could you add something like:

/* Keep is_* in chronological order */
....
/* Keep has_* in alphabetical order */
...
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list