[Intel-gfx] [PATCH 03/22] drm/i915: Shrink per-platform watermark configuration

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Wed Oct 5 16:53:35 UTC 2016


On 05/10/2016 17:50, Tvrtko Ursulin wrote:
>
> On 05/10/2016 16:07, Joonas Lahtinen wrote:
>> On ke, 2016-10-05 at 13:33 +0100, Tvrtko Ursulin wrote:
>>> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>>>
>>> Use types of more appropriate size in struct
>>> intel_watermark_params to save 512 bytes of .rodata.
>>>
>>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>> The code does seem to use datatypes very sloppily. Where did you pick
>> up these?
>
> I was just nosing around in .rodata and wondered why a huge table of 
> zeros. :)
>

Oops no, that was the cxsr table which stood out so much. After I found 
that one I nosed around some more to see which ones look wasteful.

Regards,

Tvrtko




More information about the Intel-gfx mailing list