[Intel-gfx] [PATCH 03/22] drm/i915: Shrink per-platform watermark configuration

[Tvrtko Ursulin]

On 06/10/2016 07:58, Joonas Lahtinen wrote:
> On ke, 2016-10-05 at 17:53 +0100, Tvrtko Ursulin wrote:
>> On 05/10/2016 17:50, Tvrtko Ursulin wrote:
>>>
>>> On 05/10/2016 16:07, Joonas Lahtinen wrote:
>>>> On ke, 2016-10-05 at 13:33 +0100, Tvrtko Ursulin wrote:
>>>>> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>>>>>
>>>>> Use types of more appropriate size in struct
>>>>> intel_watermark_params to save 512 bytes of .rodata.
>>>>>
>>>>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>>>> The code does seem to use datatypes very sloppily. Where did you
>>>> pick
>>>> up these?
>>> I was just nosing around in .rodata and wondered why a huge table
>>> of
>>> zeros. :)
>>>
>> Oops no, that was the cxsr table which stood out so much. After I
>> found
>> that one I nosed around some more to see which ones look wasteful.
>>
> I rather meant how did you deduce the right datatype sizes?
>

Oh right, I've looked at the values stored in them and got extra 
confidence when the compiler did not complain.

Regards,

Tvrtko