[Intel-gfx] [PATCH 4/9] drm/i915: Shrink TV modes const data

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Mon Oct 10 07:22:25 UTC 2016


On pe, 2016-10-07 at 14:34 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> Make struct video_levels and struct tv_mode use data types
> of sufficient width to save approximately one kilobyte in
> the .rodata section.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Would it hurt us to make the struct packed?

I can see why not to reorder the struct (although, it uses designated
initializers, so it should not matter in that sense).

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list