[Intel-gfx] [PATCH i-g-t 1/5] tests: Use bash for debugfs_wedged and drm_lib.sh

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Wed Oct 12 11:29:17 UTC 2016


On ke, 2016-10-12 at 14:16 +0300, Jani Nikula wrote:
> If you really care, go ahead and send the patches to make these Bourne
> shell compatible, but then do also sign up for testing them on non-bash
> shells. The CI won't. I don't think it's worth the trouble, but YMMV.

If they're re-written using POSIX sh constructs only, I don't think
they need to be tested outside of POSIX sh? That's what standards are
for.

I also remember FreeBSD guys being all for letting bash dependency go.
So there'd be actual gains too.

./scripts/run-tests.sh:            Bourne-Again shell script, UTF-8 Unicode text executable
./scripts/who.sh:                  Bourne-Again shell script, ASCII text executable
./tests/vgem_reload_basic:         Bourne-Again shell script, ASCII text executable
./tests/debugfs_emon_crash:        Bourne-Again shell script, ASCII text executable
./tests/drv_module_reload_basic:   Bourne-Again shell script, ASCII text executable
./tests/ddx_intel_after_fbdev:     Bourne-Again shell script, ASCII text executable
./tests/test_rte_check:            Bourne-Again shell script, ASCII text executable
./tests/tools_test:                Bourne-Again shell script, ASCII text executable
./tests/check_drm_clients:         Bourne-Again shell script, ASCII text executable
./tests/sysfs_l3_parity:           Bourne-Again shell script, ASCII text executable
./tests/drv_debugfs_reader:        Bourne-Again shell script, ASCII text executable
./tests/kms_sysfs_edid_timing:     Bourne-Again shell script, ASCII text executable
./tools/intel_aubdump.in:          Bourne-Again shell script, ASCII text executable

All are easily convertible. So let's do this.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list