[Intel-gfx] [PATCH 0/8] HuC Loading Patches

Daniel Vetter daniel at ffwll.ch
Thu Oct 13 13:10:53 UTC 2016


On Thu, Sep 29, 2016 at 11:03:57AM -0700, Anusha Srivatsa wrote:
> These patches add HuC loading support. The userspace
> patches that check for a fully loaded HuC firmware and use
> it can be found at:
> https://lists.freedesktop.org/archives/libva/2016-September/004554.html
> https://lists.freedesktop.org/archives/libva/2016-September/004555.html
> 
> Peter Antoine (8):
>   drm/i915/guc: Make the GuC fw loading helper functions general
>   drm/i915/huc: Unified css_header struct for GuC and HuC
>   drm/i915/huc: Add HuC fw loading support
>   drm/i915/huc: Add debugfs for HuC loading status check
>   drm/i915/huc: Support HuC authentication
>   drm/i915/huc: Add BXT HuC Loading Support
>   drm/i915/get_params: Add GuC status to getparams
>   drm/i915/get_params: Add HuC status to getparams

So trouble with these is that both original authors (all of them) and
reviewers left intel. Which means we don't have anyone anymore who
understands this, and a big part of review is making sure that in the end
at least two people (author+reviewer) really understand the patches in
full detail.

In short we need to restart the review process here again before merging
:(
-Daniel

> 
>  drivers/gpu/drm/i915/Makefile              |   1 +
>  drivers/gpu/drm/i915/i915_debugfs.c        |  43 ++++-
>  drivers/gpu/drm/i915/i915_drv.c            |  11 ++
>  drivers/gpu/drm/i915/i915_drv.h            |   3 +
>  drivers/gpu/drm/i915/i915_guc_reg.h        |   3 +
>  drivers/gpu/drm/i915/i915_guc_submission.c |  69 ++++++-
>  drivers/gpu/drm/i915/intel_guc.h           |  46 +++--
>  drivers/gpu/drm/i915/intel_guc_fwif.h      |  17 +-
>  drivers/gpu/drm/i915/intel_guc_loader.c    | 215 ++++++++++++---------
>  drivers/gpu/drm/i915/intel_huc.h           |  44 +++++
>  drivers/gpu/drm/i915/intel_huc_loader.c    | 289 +++++++++++++++++++++++++++++
>  include/uapi/drm/i915_drm.h                |   2 +
>  12 files changed, 623 insertions(+), 120 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/intel_huc.h
>  create mode 100644 drivers/gpu/drm/i915/intel_huc_loader.c
> 
> -- 
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the Intel-gfx mailing list