[Intel-gfx] [CI 1/4] drm/i915: Shrink cxsr_latency_table

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Fri Oct 14 14:08:29 UTC 2016


On 14/10/2016 14:31, Jani Nikula wrote:
> On Thu, 13 Oct 2016, Tvrtko Ursulin <tursulin at ursulin.net> wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>>
>> unsigned long is too wide - use smaller types in
>> struct cxsr_latency to save 800-something bytes of .rodata.
>>
>> v2: All data even fits in u16 for even more saving. (Ville Syrjala)
>> v3: Move bitfields to the end of the struct. (Joonas Lahtinen)
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>> Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Please learn how to run sparse, make it a habit to run it on your local
> branches before submitting patches, and make it a rule to run it before
> pushing patches. dim has helpers for this.

Yeah I saw that you added dim sparse this week, however it only runs if 
the dim tree is used for building it seems.

I will try to figure out how to run in a separate build tree.

> The following is caused by this patch, fix or revert ASAP.

Fix sent, you are on cc.

Regards,

Tvrtko



More information about the Intel-gfx mailing list