[Intel-gfx] [PATCH v2 1/3] drm/i915: Bump object bookkeeping to u64 from size_t

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Mon Oct 17 09:48:17 UTC 2016


On ma, 2016-10-17 at 09:00 +0100, Chris Wilson wrote:
> Internally we allow for using more objects than a single process can
> allocate, i.e. we allow for a 64bit GPU address space even on a 32bit
> system. Using size_t may oveerflow.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

How might we get more than size_t passed in? I only notice a single
instance which uses obj.base->size which is size_t.

So I'd not change the function parameters, only the sum. With that;

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list