[Intel-gfx] [PATCH v3 0/4]: Picture aspect ratio support in DRM layer

[Sharma, Shashank]

Regards

Shashank

On 10/17/2016 5:01 PM, Jose Abreu wrote:
> Hi Shashank,
>
>
> On 17-10-2016 12:32, Shashank Sharma wrote:
>> This patch series adds 4 patches.
>> - The first two patches add aspect ratio support in DRM layes
>> - Next two patches add new aspect ratios defined in CEA-861-F
>>    supported for HDMI 2.0 4k modes.
>>
>> Adding aspect ratio support in DRM layer:
>> - The CEA videmodes contain aspect ratio information, which we
>>    parse when we read the modes from EDID. But while transforming
>>    user_mode to kernel_mode or viceversa, DRM layer lose this
>>    information.
>> - HDMI compliance testing for CEA modes, expects the AVI info frames
>>    to contain exact VIC no for the 'video mode under test'. Now CEA
>>    modes have different VIC for same modes but different aspect ratio
>>    for example:
>>          VIC 2 = 720x480 at 60 4:3
>>          VIC 3 = 720x480 at 60 16:9
>>    In this way, lack of aspect ratio information, can cause wrong VIC
>>    no in AVI IF, causing HDMI complaince test to fail.
>> - This patch set adds code, which embeds the aspect ratio information
>>    also in DRM video mode flags, and uses it while comparing two modes.
>>
>> Adding new aspect ratios for HDMI 2.0
>> - CEA-861-F defines two new aspect ratios, to be used for 4k HDMI 2.0
>>    modes.
>>          - 64:27
>>          - 256:135
>> Last two patches in the series, adds code to handle these new
>> aspect ratios.
>>
>> V2: Fixed review comments from Sean, Emil, Daniel
>> V3: Fixed review comments from Jim Bride, got r-b for all patches
>>
>> Shashank Sharma (4):
>>    drm: add picture aspect ratio flags
>>    drm: Add aspect ratio parsing in DRM layer
>>    video: Add new aspect ratios for HDMI 2.0
>>    drm: Add and handle new aspect ratios in DRM layer
> I am using the previous version of these patches, the
> functionality remains the same so you can add my reviewed-by for
> the whole series if you want.
Thanks Joes. I will add a V4 with your r-b.
> Are you still planning in sending
> the patches for the new VIC's introduced in CEA-861-F?
Yes, the very next step is the patch with new VICs.

Regards
Shashank
>>   drivers/gpu/drm/drm_modes.c | 43 +++++++++++++++++++++++++++++++++++++++++++
>>   drivers/video/hdmi.c        |  4 ++++
>>   include/linux/hdmi.h        |  2 ++
>>   include/uapi/drm/drm_mode.h | 24 +++++++++++++++++++-----
>>   4 files changed, 68 insertions(+), 5 deletions(-)
>>
> Best regards,
> Jose Miguel Abreu